search

MOj0 / LoR-Bot

Bot for Legends of Runeterra
MIT License
27 stars 14 forks source link

Bot not passing turn when it has no mana/no moves #20

Closed itzShazo closed 10 months ago

itzShazo commented 1 year ago

Everything about the bot other than passing turn works well, when it runs out of moves it throws the "06IO014" card set error. This doesn't always happen however, and in the beginning of a game it often times doesn't throw any error, and just stalls, making me think the two issues are unrelated. I have deleted the card_sets folder and re downloaded, as well as making sure I have all dependencies installed. Unfortunately this bot is useless without the ability to pass turns. It still maintains the ability to pass after blockers and attacking.

MOj0 commented 1 year ago

Hi, regarding the card set error, see if this fix works https://github.com/MOj0/LoR-Bot/issues/17#issuecomment-1352674350. This was an issue because normally, card sets are named as set1-lite, set2-lite and so on, but some sets were suddenly named like set6cde-lite. I don't remember if I implemented downloading those through code (I think I did though), so you might have to manually download those. If it still throws the card set error, I will have to look at it this weekend. For the stalling issue, I have no idea why would it do that. If it doesn't have anything to play it should pass the turn... Can you provide more info about this? I would suggest running it in debug mode and when it stalls setting a break-point somewhere and try to figure out what is going on. Anything which you manage to find, post it here I and will take a look at it.

itzShazo commented 1 year ago

Ok I think I figured out a fix. Make sure to have "auto pass" enabled in your settings. This fixed the bot hanging on obvious passing turns. This isn't an issue with the bot, but maybe add that to the prereq section that includes the resolution and port number settings?

itzShazo commented 1 year ago

Also I fixed the card set not being recognized using the solution in the other issue. I had to download specifically the one that had "set6cde" in it, as it wasnt in the card sets folder.

MOj0 commented 1 year ago

Ah, seems I will need to implement it, such that it also downloads those card sets... Also what do you mean by Make sure to have "auto pass" enabled in your settings? If by including you mean README, you can open a PR for that :)