MPAS-Dev / MPAS-Analysis

Provides analysis for the MPAS components of E3SM
Other
55 stars 52 forks source link

If not generating a climatology, the climatology bounds should not be checked #780

Open xylar opened 3 years ago

xylar commented 3 years ago

@alicebarthel found this in runs that start at year 50 (but 21 to 30 are the defaults).

The same should be true for time series and climate indices.

xylar commented 3 years ago

@alicebarthel, any other comments on this?

xylar commented 3 years ago

I've looked into this. It might be kind of tricky. It will likely involve creating a task to update the bounds with dependencies on other tasks. I'll give it a whirl. But since it's not an easy fix, I'm demoting it to not being a high priority right now.

xylar commented 3 years ago

The task approach doesn't work. The bounds get updated too late to be useful. Still thinking about how to solve this.

milenaveneziani commented 3 years ago

@xylar: my only suggestion would be, when one runs with the --verbose flag, to add a comment before or after the bounds checking of the like "Warning: climatology bounds are checked even if climatology task is off".

xylar commented 3 years ago

Yeah, that might be an easy interim solution.