MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
237 stars 318 forks source link

Copy xml_stream_parser.c from master to maint-1.0 #1048

Closed ndkeen closed 1 year ago

ndkeen commented 1 year ago

Copying this file from E3SM master (as of April 27 2023) to allow compilation on maint-1.0 with Intel compiler.

Avoids:

xml_stream_parser.c:1732:6: error: call to undeclared function 'stream_mgr_add_field_c'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                                        stream_mgr_add_field_c(manager, streamID, (const char *)fieldname, packages_local, &err);

[bfb]

ndkeen commented 1 year ago

I don't know how to cherry-pick. Would it make more sense for someone with knowledge of what this is doing to make PR?

jonbob commented 1 year ago

verified that @xylar's recommended cherry-pick allows maint-1.0 to successfully complete all-active tests. Working now on getting the fix committed