search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
238 stars 317 forks source link

Bug fix in call to the parameterization of the gravity wave drag over orography #1078

Closed ldfowler58 closed 1 year ago

ldfowler58 commented 1 year ago

This PR corrects a bug discovered by Wei Wang in the call to the subroutine gwdo in mpas_atmphys_driver_gwdo.F. In the earlier version, the variable z was erroneously defined as the height at the interface between layers, or z = z_p where z_p is equal to zgrid. In the corrected version, the variable z is now defined as the height defined at the middle of layers, or z = zmid_p, as needed by subroutine gwdo.

mgduda commented 1 year ago

@ldfowler58 Is it only the last of the commits (da30ff91) in this PR branch that is actually needed? If so, I can rebase this branch to avoid the inclusion of the first five commits.

weiwangncar commented 1 year ago

@ldfowler58 @mgduda It looks like most of the changed files do not belong to this PR. @ldfowler58 The PR message is good.