search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
238 stars 317 forks source link

Correct several Fortran 2008 compliance issues in physics_mmm #1086

Closed mgduda closed 1 year ago

mgduda commented 1 year ago

This PR corrects Fortran 2008 compliance issues in physics modules that were caught by the GNU Fortran compiler when using the -std=f2008 flag. Most of these issues are related to the use of non-standard kind/type specifications.

ldfowler58 commented 1 year ago

I completely agree with your updates proposed in cu_ntiedtke.F and mp_radar.F. Regarding module_libmassv.F, it may be cleaner to add the definitions of R4KIND and R8KIND in ccpp_kinds.F instead of defining them as private at the top of the modules.

ldfowler58 commented 1 year ago

I can work on this, of course, if you agree.