search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
231 stars 308 forks source link

Add da_state input/output stream #1167

Closed jim-p-w closed 1 month ago

jim-p-w commented 2 months ago

This PR adds a "da_state" inout/output stream. This stream is only used by MPAS-JEDI. This stream is associated with the "jedi_da" package, and so it will only be active if config_jedi_da = true.

jim-p-w commented 1 month ago

Besides removing sfc_albedo_seaice, I would suggest including at least a couple of additional points in the PR description: (1) this stream is only used by MPAS-JEDI, and (2) the stream is associated with the "jedi_da" package, and so it will only be active if config_jedi_da = true.

Should I add points (1) and (2) to the commit message too?

mgduda commented 1 month ago

Should I add points (1) and (2) to the commit message too?

Sure, I think that would be good in case someone happens upon the commit itself and not the merge commit (for which we'll use the PR description).