Implementation of manage_externals

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.

239 stars 319 forks source link

Implementation of manage_externals #1171

Closed ldfowler58 closed 4 months ago

ldfowler58 commented 4 months ago

This PR introduces the use of the manage_externals tool to access the github repository NCAR/MMM-physics.git, and download the directory physics_mmm. NCAR/MMM-physics.git contains physics parameterizations shared by MPAS, WRF, and CM1. Modules follow CCPP coding standards.

Testing of all changes made in this PR was done using the develop branch (commit 61f0bd0dab2adbc25bdbf9cc) on the NSF NCAR supercomputer derecho using intel/2023.2.1 and gcc/13.2.0:

Added CCPP compliance for all the modules contained in MMM-physics produce bit for bit reproducilbity of the physics_mmm develop branch with O3 optimization, except for mp_wsm6.F90 with both the intel and gcc compilers.
Bit for bit reproducibility of the physics_mmm develop branch is achieved with no optimization (-g) and O1 optimization.

mgduda commented 4 months ago

It looks like this PR branch has quite a few additional commits at the beginning. Are these needed, or is it just the last few commits that we want?

I would suggest we omit the test directory from manage_externals, and we should definitely include the LICENSE.txt file (and maybe also the version.txt file).

If I can help in reworking the branch, just let me know!

ldfowler58 commented 4 months ago

I removed the ./test directory and added the files LICENSE.txt and version.txt files. The commit is at the top of all commits. Can you please move that commit close to 7cf34a2e8bc8, as you suggested in your previous email. I reworked everything using the branch that was originally committed (50134e0173). Thanks.

mgduda commented 4 months ago

@ldfowler58 No problem -- I've just rebased the branch to squash what was the last commit into 7cf34a2e.

mgduda commented 4 months ago

Just one final change: I'm going to remove these files/directories from manage_externals as well:

.dir_locals.el
.github/ISSUE_TEMPLATE.md
.github/PULL_REQUEST_TEMPLATE.md
.github/workflows/bumpversion.yml
.github/workflows/tests.yml
.travis.yml

ldfowler58 commented 4 months ago

Many thanks for your help.

favba commented 3 months ago

Hi @ldfowler58 ,

Since this PR was merged I am unable to compile the develop branch. The issue is that I can't git clone git@github.com:NCAR/MMM-physics.git. Git complains the repository doesn't exist. Is it a private repo?

My group has a modified version of MPAS (at https://github.com/pedrospeixoto/MPAS-BR). I periodically merge the latest developments into our own develop branch so as not to diverge too much from NCAR's development. Will this MMM-physics git repo be made public only when a new version of MPAS is officially released with this change or was it just an oversight?

mgduda commented 3 months ago

@favba I think you're right -- the https://github.com/NCAR/MMM-physics repository is still private, but the intent is definitely to make this public. I should have checked the permissions on that repository before I approved and merged this PR. We'll get this sorted out soon!

ldfowler58 commented 3 months ago

Thank you for pointing out that the https://github.com/NCAR/MMM-physics repository is still private. We did change the permission to make the repository public and you should be be able to download it when you compile MPAS-Model. Let us know if you still have issues, of course!

favba commented 3 months ago

Thank you guys! I can confirm the repo is available and I'm able to compile the develop branch again!