search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
231 stars 308 forks source link

Add OpenACC module to core_test #1175

Closed gdicker1 closed 1 month ago

gdicker1 commented 1 month ago

This PR adds a new module to the test core that will be used to test OpenACC functionality and any OpenACC-specific framework routines that are added to MPAS. The only test added in this PR is based on patterns from the MPAS-A dycore. If the test core is compiled without OPENACC=true, the OpenACC tests are skipped.

gdicker1 commented 1 month ago

Also includes changes to LDFLAGS that are in #1174.

mgduda commented 1 month ago

Also includes changes to LDFLAGS that are in #1174.

With PR #1174 merged, I think it would be safe to rebase this PR.

gdicker1 commented 1 month ago

With PR #1174 merged, I think it would be safe to rebase this PR.

Addressed by force push from b5d2a99 to 690909e

gdicker1 commented 1 month ago

These comments should be addressed by the push from cdc2ac0 to 054078d

I removed the diff_arrs_1d routine, removed the use mpas_dmpar ... from openacc_test_rep_arrs, and initialized diff to 0.0 in openacc_test_rep_arrs

gdicker1 commented 1 month ago

Thank you for pointing that out, I neglected to fix the macro spacing in the first commit in the sequence. I checked with gnu on Derecho, the push from 054078d to b276568 addresses this.