search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
239 stars 319 forks source link

Make the registry 'parse' tool core-independent #1180

Closed mgduda closed 3 months ago

mgduda commented 3 months ago

This PR introduces changes to allow the registry parse tool to be core-independent, with any core-dependent output that it produces depending only on run-time arguments.

The parse tool now requires its first command-line argument to be the name of a Registry.xml file, and it requires subsequent arguments that specify definitions of at least the following macros in the form -D<macro>=<value>:

Additionally, this PR updates the main Makefile for each core so that the processed Registry.xml file is passed as the first command-line argument to parse and the contents of $(CPPFLAGS), which contains definitions of at least the aforementioned macros, as subsequent command-line arguments.

mgduda commented 3 months ago

@gdicker1 With the changes in this PR, I think PR #1179 will actually work as intended.

mgduda commented 3 months ago

@gdicker1 I've just pushed three new commits to fix a couple of minor issues. Before this PR is ultimately merged, I'll squash those commits.

mgduda commented 3 months ago

@gdicker1 Thanks! I just force-pushed the rebased branch, and I confirmed that no changes were inadvertently made during the rebase with git diff a2df6eed b8f077cc.