search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
239 stars 319 forks source link

Add ONLY clause to USE statements for the 'mpi_f08' module #1188

Closed mgduda closed 3 months ago

mgduda commented 3 months ago

This PR adds ONLY clauses to all USE statements for the mpi_f08 module in MPAS.

Besides being a generally good practice, the use of only those entities from the 'mpi_f08' module that are actually needed eliminates link-time issues with debug builds using the Intel oneAPI compilers (with the Cray MPICH library).

mgduda commented 3 months ago

When combined with PR #1187, DEBUG=true builds with the intel/2024.0.2 module on Derecho should be successful. However, runs fail almost immediately due to what look like issues with uninitialized variables. So there may be another PR needed to turn off some checks (for example, changing -check all to something like -check pointers,bounds).