search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
231 stars 307 forks source link

Add 'sf_noahmp_in' package to Noah-MP static fields in atmosphere core registry #1194

Closed mgduda closed 3 weeks ago

mgduda commented 3 weeks ago

This PR adds the sf_noahmp_in package to Noah-MP static fields in the atmosphere core's Registry file.

Prior to this PR, the Noah-MP static fields soilcomp, soilcl1, soilcl2, soilcl3, and soilcl4 did not have any packages attached to them, and as a result, even model simulations that didn't use the Noah-MP scheme would attempt to read these fields from input files. If attempting to run a simulation with the default 'mesoscale_reference' physics suite and an old (<= v8.1.0) input file, the model run would fail when trying to inquire about the nSoilComps dimension:

  ERROR: At least one fields to be read from the 'input' stream is dimensioned
  ERROR: by 'nSoilComps', but the 'nSoilComps' dimension is not defined
  ERROR: in the file <input stream filename>.
  CRITICAL ERROR: Please check the input file(s) to be read by the 'input' input stream.

Since these static fields are only needed by the Noah-MP scheme, this PR attaches the existing sf_noahmp_in package to these five fields so that they will only be active, and therefore, only read, if config_lsm_scheme = 'sf_noahmp' in the &physics namelist group.

ldfowler58 commented 3 weeks ago

After discussing this PR during the coffee break and looking at the updated Registry_noahmp.xml, I am ready to approve this PR.