search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
239 stars 319 forks source link

Fix instances of unbalanced quotes in init_atmosphere and atmosphere registries #1195

Closed mgduda closed 3 months ago

mgduda commented 3 months ago

This PR fixes several instances of unbalanced quotes in the init_atmosphere and atmosphere Registy.xml files.

mgduda commented 3 months ago

I'll update the commit message and PR description (but no changes to diffs) with a few more details. The registry-generated code is different in ways that I'm testing more carefully. For example, we previously had generated code like this for rnifampten:

      call mpas_add_att(r2Ptr % attLists(1) % attList, 'long_name', 'tendency of ')
      call mpas_add_att(r2Ptr % attLists(1) % attList, 'ice-friendly"', '')
      call mpas_add_att(r2Ptr % attLists(1) % attList, 'aerosol', '')
      call mpas_add_att(r2Ptr % attLists(1) % attList, 'number', '')
      call mpas_add_att(r2Ptr % attLists(1) % attList, 'concentration', '')
      call mpas_add_att(r2Ptr % attLists(1) % attList, 'due', '')
      call mpas_add_att(r2Ptr % attLists(1) % attList, 'to', '')
      call mpas_add_att(r2Ptr % attLists(1) % attList, 'microphysics"', '')

whereas we now get

      call mpas_add_att(r2Ptr % attLists(1) % attList, 'long_name', 'tendency of ice-friendly aerosol number concentration due to &
&microphysics')

The latter is clearly correct while the badly nested quotes led to the former incorrect code.

mgduda commented 3 months ago

The last force-push just corrects a typo in the commit message.