MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
239 stars 319 forks source link

Add core_physics dependencies for mpas_atmphys_lsm_noahmpfinalize module #1204

Closed islas closed 2 months ago

islas commented 3 months ago

Module mpas_atmphys_lsm_noahmpfinalize added in #1161 does not have the appropriate dependencies in the respective makefile.

This adds the necessary dependencies to the mpas_atmphys_lsm_noahmpfinalize.o

mgduda commented 2 months ago

@islas Can you add some detail to the commit message (and use capitalization where appropriate)? A couple of questions to consider for the commit message:

islas commented 2 months ago

Is this roughly what you are looking for from the commit message?

Add the minimum object dependencies in the makefile for mpas_atmphys_lsm_noahmpfinalize.o. This corresponds to all unresolved modules used yet to be compiled by the time this rule is evaluated. Modules originating from NoahMP and framework are ignored as they should be handled separately before the core_physics target is started.

I'm refraining from saying "NoahMP and framework are already compiled by the time the core_physics target is started" since the fix is based on a commit that does not have those fix in it, thus would be referring to future patches that have yet to occur if one were to try and take this individual commit.