search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
241 stars 321 forks source link

Verify SAL for RK4 (wetting / drying cases) #458

Open pwolfram opened 4 years ago

pwolfram commented 4 years ago

Tidal implementation of SAL for RK4 may be incorrect in #371 at https://github.com/MPAS-Dev/MPAS-Model/pull/371/files#diff-d2a9414bd0f5332537025544c6ed7ea9R357

Currently, SAL is computed as a perturbation off the layer potential: - config_self_attraction_and_loading_beta * zMid(k,iCell) and this may not be correct.

Given the approximation really is only deep water as the reference below implies, maybe we should do something like this: - config_self_attraction_and_loading_beta * (bottomDepth > 100)*ssh(iCell)

We wouldn't do any SAL for shallow waters with less than 100m depth. A cleaner way to do this is to use a tanh function that goes from 0 for bottomDepth < 100m and to 1 by bottomDepth ~ 1000m.

Reference: image

pwolfram commented 4 years ago

Needed for #366 final case with full SAL, which is only a minor correction to current approach.

pwolfram commented 4 years ago

Closed by #498, thanks @sbrus89!

pwolfram commented 4 years ago

Reopening-- unclear if SAL is working correctly based on preliminary testing and it is currently turned off in #520