search

MPAS-Dev / MPAS-Tools

MPAS Tools Repository
Other
37 stars 63 forks source link

Fix uninitialized values in kiteAreasOnVertex #431

Closed xylar closed 3 years ago

xylar commented 3 years ago

Previously, the MPAS mesh converter was not initializing all values in the temporary buffer for writing out kiteAreasOnVertex, meaning some areas for nonexistent cells had garbage values. This can cause MPAS model to fail in debug mode with arithmetic errors.

xylar commented 3 years ago

@mgduda, @akturner and @matthewhoffman. This is an issue that is messing up compass when we run in debug mode. I'd like you all to review (either just by inspection or running some tests if you feel the need) since the mesh converter is one of the most important bits of infrastructure that we share.

akturner commented 3 years ago

@xylar: Looks good.

xylar commented 3 years ago

Thanks @matthewhoffman and @akturner for reviewing so quickly.

xylar commented 3 years ago

@mgduda, I'm guessing we'd have problems elsewhere too if meshes got that big. But worth having in mind. Thanks for the quick review!