MPAS-Dev / MPAS-Tools

MPAS Tools Repository
Other
37 stars 63 forks source link

Update performance script to python 3, and minor corrections #433

Closed mark-petersen closed 3 years ago

mark-petersen commented 3 years ago

Minor script updates. With these changes, the script produces performance scaling plots correctly.

mark-petersen commented 3 years ago

In a run directory, the command

./performance_test.py 1024 32 grizzly 36 EC60to30

produces this plot: EC60to30_grizzly_1024_20210719_081846

xylar commented 3 years ago

@mark-petersen, if you want to make the one suggested change above, I'll approve by inspection. If you would like me to test, please let me know what typical usage looks like.

xylar commented 3 years ago

@mark-petersen, based on your typical usage above (our messages crossed!), would you be willing to add argparse to this script so the arguments are named, rather than ordered and so there's help when you do ./performance_test.py --help.

Should we add this to the conda package?

xylar commented 3 years ago

If the answer is no to all of the above, that's fine.

mark-petersen commented 3 years ago

@xylar I agree about argparse. I had thought of that too. If you approve I'll merge this in now so students can use it, and argparse is a good exercise for a student to update.

mark-petersen commented 3 years ago

@xylar no need to test, visual inspection is fine.