search

MPAS-Dev / MPAS-Tools

MPAS Tools Repository
Other
37 stars 63 forks source link

Add analysis script for plotting regional stats #471

Closed matthewhoffman closed 1 year ago

matthewhoffman commented 2 years ago

This script is modified from the global stats script. It plots three different figures, each with subpanels for each region. The first is overall mass change statistics. The second is the grounded mass balance, and the third is the floating mass balance. It is possible to plot up to four runs, each with a different linestyle, but because of the number of lines on each plot, plotting multiple runs is not pretty.

matthewhoffman commented 2 years ago

@trhille , thanks for the review a few weeks ago. The script has obviously evolved quite a bit since then, so I'll wait to implement changes until we're happy with it.

Also, I've added two new scripts to this PR for tuning of initial condition files related to the ISMIP6-2300 issues we've been discussing. They are not directly related to this script, but I put them in the same PR because it's much easier to have all 3 scripts in the same branch and they are all new scripts. Like this script, I tried to strike a balance between flexibility and complexity, but we can shift that balance as desired (e.g. move more things to command line options).

trhille commented 2 years ago

@matthewhoffman, I've reviewed the two new pre-processing scripts. I still need to re-review plot_regional_stats.py, but I wanted to look those two over to test out https://github.com/MALI-Dev/E3SM/pull/48

matthewhoffman commented 1 year ago

@trhille , now that things have settled down with our ISMIP6 workflow, I finally cleaned up this PR. I deleted a few scripts that did not end up being relevant, and I responded to review comments and did general cleanup with the others. I responded directly to comments above for which I had a response. For those without a response, I simply made the changes.

I realize there is a lot to review in this PR; if you prefer this be broken into a couple PRs for different scripts, I can do that. Also, there is no real rush to get this re-reviewed and merged, but it would be nice to check this off and have it on master before too much time goes on. I'll leave it up to you regarding the level of detail you think further review warrants.

matthewhoffman commented 1 year ago

@trhille , I pushed another cleanup commit addressing your latest round of review. I think this should be ready to go now.