search

MPAS-Dev / MPAS

Repository for private MPAS development prior to the MPAS v6.0 release.
Other
4 stars 0 forks source link

Ocean model is incorrectly using forcing #1454

Open akturner opened 6 years ago

akturner commented 6 years ago

There should only be a single forcing group object declaration per core as per https://github.com/MPAS-Dev/MPAS/pull/1333. Ocean/develop currently has multiple declarations of forcing group - THIS IS WRONG AND NOT HOW FORCING IS MEANT TO BE USED!. IT WILL NOT WORK WITH THE NEW RESTART SYSTEM. The forcing group object is the head of a linked list of forcing group objects, hence only one needs to be declared.

vanroekel commented 6 years ago

Thanks for bringing this up @akturner, I misunderstood the implementation of your new forcing changes. Am I correct that issues will occur as soon as we attempt to use two forcing groups in the ocean core?

akturner commented 6 years ago

@vanroekel: Hi Luke, yes, more than one forcing group declaration will not work with the restarts