search

MPAS-Dev / MPAS

Repository for private MPAS development prior to the MPAS v6.0 release.
Other
4 stars 0 forks source link

Remove mpas_threading.o dependency on mpas_log.o #1539

Closed mgduda closed 6 years ago

mgduda commented 6 years ago

This merge removes an incorrect dependency of mpas_threading.o on mpas_log.o in src/framework/Makefile.

The Makefile in src/framework incorrectly had a dependency on mpas_log.o for the mpas_threading.o file, which caused a circular dependency reported by make:

make[3]: Circular mpas_threading.o <- mpas_log.o dependency dropped.

In fact, the mpas_threading module does not use the mpas_log module (though mpas_log does use mpas_threading), so we can remove the dependency of mpas_threading.o on mpas_log.o in src/framework/Makefile.

mgduda commented 6 years ago

@matthewhoffman I've added you as a reviewer for this PR, but feel free to assign anyone else at LANL. Also, we can re-target the release-v6.0 branch once it has been created, if you'd prefer.

mgduda commented 6 years ago

OK, I'll merge this in just a few minutes.