ocean SSS restoring not working correctly

maltrud commented 5 years ago

The value of the climatological SSS field that is used for SSS restoring is not being updated correctly. i ran a E3SM G-case for 15 months and while the first month agreed with the read-in climatology file, subsequent months didn't change much--certainly no seasonal cycle.

i am currently testing a version of the code from before the following commit to see if that may be the cause.

commit d2a7f499a5c56b0f413161489fb810811b5e9096 Author: Mark Petersen mpetersen@lanl.gov Date: Thu Nov 16 10:09:34 2017 -0700

Only a single forcing group linked list should exist per core.

These were put in by Adrian in PR 1333, but then removed
inadvertenly in PR 1427

akturner commented 5 years ago

@maltrud: Nothing obviously wrong with what was done in that PR

mark-petersen commented 5 years ago

Moved to https://github.com/MPAS-Dev/MPAS-Model/issues/120. Please comment there.

MPAS-Dev / MPAS

ocean SSS restoring not working correctly #1549