Closed trhille closed 7 months ago
I ran the koge bugt mesh gen case (93) and it ran successfully. I had not update MPAS-Tools to include https://github.com/MPAS-Dev/MPAS-Tools/pull/551 but because there are no negatives in the basalHeatFlux field, there was no problem.
Realized I could test all the mesh gen tests that are affected at once with a custom suite (compass setup -n 0 43 44 92 93 99
), and that would be the more robust test. This time it also includes https://github.com/MPAS-Dev/MPAS-Tools/pull/551 (which as said in previous comment won't actually be needed).
Test Runtimes:
11:44 PASS landice_antarctica_mesh_gen
08:28 PASS landice_greenland_mesh_gen
07:30 PASS landice_humboldt_mesh_gen
00:31 PASS landice_kangerlussuaq_mesh_gen
00:46 PASS landice_koge_bugt_s_mesh_gen
05:32 PASS landice_thwaites_mesh_gen
Total runtime 34:31
PASS: All passed successfully!
which as said in previous comment won't actually be needed
@matthewhoffman, https://github.com/MPAS-Dev/MPAS-Tools/pull/551 is needed for the Antarctic meshes, because that data file contains NaNs. The Greenland one does not, so those should pass without the MPAS-Tools branch.
Ah, thanks, I missed that distinction, but I see you indicated that in the description
Update file names on LCRC server to use files that do not have negative basal heat flux.
Note: The Antarctic data files still include NaNs as missing values. This requires the changes in https://github.com/MPAS-Dev/MPAS-Tools/pull/551 to pass.
Checklist
Testing
in this PR) any testing that was used to verify the changes