Add a tides test case for the VR45to5 mesh

MPAS-Dev / compass

Configuration Of MPAS Setups

Other

10 stars 37 forks source link

Add a tides test case for the VR45to5 mesh #802

Open sbrus89 opened 5 months ago

sbrus89 commented 5 months ago

This PR adds the workflow to generate the mesh and initial conditions for the VR45to5 barotropic tides mesh, run the simulation, and perform the global tidal constituent error analysis. It relies on the developments from https://github.com/E3SM-Project/E3SM/pull/6310. This case reproduces the MPAS-Ocean configuration that gives the best deep water M2 RMSE accuracy (3.3 cm compared to TPXO9) to date.

Checklist

[x] User's Guide has been updated
[x] Developer's Guide has been updated
[x] API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
[x] Documentation has been built locally and changes look as expected
[x] The E3SM-Project submodule has been updated with relevant E3SM changes
[x] Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

sbrus89 commented 5 months ago

Testing

The mesh generated looks like: mesh_EC

Land ice draft is included in the init step ice_draft

Bathymetric slopes and buoyancy frequency climatology are calculated/interpolated in the init step for topographic wave drag parameterizations: bathy_slope

The harmonic constituents are compared against TPXO9 in the analysis step: M2_plot N2_plot S2_plot O1_plot K1_plot

dengwirda commented 5 months ago

Not relevant to this PR specifically, but since the errors in M2 are quite competitive here, I wonder if tuning for other constituents too (RMSE_total: https://gmd.copernicus.org/articles/14/1125/2021/) may make sense in the future, so as not to over fit on M2.

xylar commented 3 months ago

@sbrus89, thanks for the reminder. I'm testing an update to the submodule now.

xylar commented 3 months ago

@sbrus89, as I just mentioned on slack, my attempt to update the submodule was not very successful. https://github.com/E3SM-Project/E3SM/pull/6310 seems to be causing segfaults on Chrysalis with Intel and OpenMPI.

sbrus89 commented 3 months ago

@xylar, the segfault issues should be fixed via #825, which turns off topographic wave drag for the global ocean test cases. We should only test config_use_topographic_wave_drag=.true. for tides cases like the one in this PR.

xylar commented 3 months ago

Almost there, just waiting on #827

xylar commented 3 months ago

@sbrus89, now that #827 is in, can you rebase and test one last time? Then, I'll merge.

sbrus89 commented 3 months ago

@xylar, yes I will do that. Thanks for helping with the submodule update!

xylar commented 2 months ago

Following up from a month ago, a reminder to rebase and retest.