Clean up `iceshelf` framework

MPAS-Dev / compass

Configuration Of MPAS Setups

Other

10 stars 37 forks source link

Clean up `iceshelf` framework #816

Closed xylar closed 4 months ago

xylar commented 4 months ago

This PR has some clean up needed to make SSH adjustment in the iceshelf framework work for adjusting SSH instead of land-ice pressure.

This was pulled out of #813 because that work no longer uses the iceshelf framework.

Checklist

[x] Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

xylar commented 4 months ago

I tried testing this on Chrysalis on Friday and was getting unexpected non-BFB results in tests without ice-shelf cavities. I think it may be just the Chrysalis weirdness that we have been experiencing lately. I'm going to wait until #810 has gone in because I'm hoping that will fix the issues.

xylar commented 4 months ago

Testing

I ran the pr suite with these changes, using the current master as a baseline. All tests passed.