MPAS-Dev / compass

Configuration Of MPAS Setups
Other
10 stars 37 forks source link

Add ISMIP6 Greenland region masks that extend beyond ice edge #824

Closed trhille closed 3 months ago

trhille commented 3 months ago

This merge adds ISMIP6 region masks to the Greenland mesh, which extend beyond ice edge and will be useful for regional stats. It also makes use of the allTags argument when calling GeometricFeatures.read() instead of looping over tags for greater flexibility.

Note: This requires geometric_features version 1.4.0, which is not yet in the latest version of compass.

Checklist

trhille commented 3 months ago

Testing

Here are the ISMIP6 basins on a 30–100 km GIS mesh: image image image image image image image

The Zwally basins remain unchanged (I won't bother adding screenshots here).

trhille commented 3 months ago

Thanks, @xylar. What's the protocol for a PR like this that requires updates to the compass environment (geometric_features=1.4.0)?

xylar commented 3 months ago

Ah, missed that. You also need to bump to alpha.2 (maybe in a couple of places).

xylar commented 3 months ago

I'll push a commit to update geometric_features and compass itself. I'd also like to add a commit to make the ocean masks for these regions in files_for_e3sm if that's okay with you.

andrewdnolan commented 3 months ago

Tested on perlmutter with the default parameters and everything worked fine for me!

landice/greenland/mesh_gen
  * step: mesh
  test execution:      SUCCESS
  test runtime:        17:13
Test Runtimes:
17:13 PASS landice_greenland_mesh_gen
Total runtime 18:37
PASS: All passed successfully!

Also took a look over the code and everything looks good to me!