Closed trhille closed 3 months ago
Here are the ISMIP6 basins on a 30–100 km GIS mesh:
The Zwally basins remain unchanged (I won't bother adding screenshots here).
Thanks, @xylar. What's the protocol for a PR like this that requires updates to the compass environment (geometric_features=1.4.0)?
Ah, missed that. You also need to bump to alpha.2 (maybe in a couple of places).
I'll push a commit to update geometric_features and compass itself. I'd also like to add a commit to make the ocean masks for these regions in files_for_e3sm
if that's okay with you.
Tested on perlmutter
with the default parameters and everything worked fine for me!
landice/greenland/mesh_gen
* step: mesh
test execution: SUCCESS
test runtime: 17:13
Test Runtimes:
17:13 PASS landice_greenland_mesh_gen
Total runtime 18:37
PASS: All passed successfully!
Also took a look over the code and everything looks good to me!
This merge adds ISMIP6 region masks to the Greenland mesh, which extend beyond ice edge and will be useful for regional stats. It also makes use of the
allTags
argument when callingGeometricFeatures.read()
instead of looping over tags for greater flexibility.Note: This requires geometric_features version 1.4.0, which is not yet in the latest version of compass.
Checklist
Testing
in this PR) any testing that was used to verify the changes