search

MPAS-Dev / compass

Configuration Of MPAS Setups
Other
10 stars 37 forks source link

Turn off topographic wave drag in global ocean cases #825

Closed sbrus89 closed 3 months ago

sbrus89 commented 3 months ago

Following https://github.com/E3SM-Project/E3SM/pull/6310, using config_use_topographic_wave_drag=.true. in global ocean test cases causes a segfault in the init routine for the topographic wave drag tendency, since the input streams required to calculate the wave drag coefficient are not available. Going forward, testing for this term should be restricted to barotropic tides cases.

xylar commented 3 months ago

I agree, this is an easy fix. I'm testing with https://github.com/E3SM-Project/E3SM/pull/6310 and this fix again to make sure I don't see failures.

xylar commented 3 months ago

@sbrus89, I'm running into the next problem. I'm seeing large changes in the MPAS-Ocean initial condition with https://github.com/E3SM-Project/E3SM/pull/6310. I'm particularly concerned about layer thickness changing by almost 50 meters. Was that expected?

temperature          Time index: 0
0:  l1: 2.27637334333235e-01  l2: 1.11516709942908e-01  linf: 8.72718501873520e-02
  ^[[91mFAIL^[[0m /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/02_6310_6263/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/01_6263_current/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
salinity             Time index: 0
0:  l1: 1.70470656169076e+00  l2: 7.73227305819931e-01  linf: 4.48482210319820e-01
  ^[[91mFAIL^[[0m /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/02_6310_6263/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/01_6263_current/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
layerThickness       Time index: 0
0:  l1: 1.89498290361250e+07  l2: 8.42600914438455e+04  linf: 4.97210844272311e+02
  ^[[91mFAIL^[[0m /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/02_6310_6263/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
       /lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240530/update_e3sm_project/01_6263_current/ocean/global_ocean/Icos240/WOA23/init/initial_state/initial_state.nc
Baseline validation failed
xylar commented 3 months ago

The issue above is unrelated to this PR and has been fixed in E3SM (https://github.com/E3SM-Project/E3SM/pull/6454).