Fix land- and land-ice-locked cells

MPAS-Dev / compass

Configuration Of MPAS Setups

Other

10 stars 37 forks source link

Fix land- and land-ice-locked cells #844

Closed xylar closed 1 month ago

xylar commented 1 month ago

We need to address land-locked and land-ice-locked cells within the process for flood-filling to ensure that the land-ice mask is connected. Otherwise, land-ice-locked cells added to the land-ice mask can create new regions of open ocean within the land ice.

Checklist

[x] Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

xylar commented 1 month ago

Testing

I created a new SORRM r3 (#807) land-ice mask during the cull_mesh step with this procedure. Whereas before this fix there is a region of isolated open ocean surrounded by land or land ice near Stange Ice Shelf: stange_orig this is filled in with land-ice with this fix: stange_fix

Results are in:

/lcrc/group/e3sm/ac.xylar/compass_1.4/chrysalis/test_20240718/fix_land_ice_flood_fill/ocean/global_ocean/SOwISC12to30/mesh/cull_mesh

xylar commented 1 month ago

My actual preferred fix is to add a critical passage to keep this location (called the Carroll Inlet) open, see https://github.com/MPAS-Dev/geometric_features/pull/203. But the algorithm here is behaving consistently with what we want the general solution to these kinds of issues to be.

xylar commented 1 month ago

Thanks @darincomeau!