search

MPCatalog / scom-community-catalog

This repository stores the MP information for the SCOM Community Management Pack Catalog
http://www.squaredup.com/MPCatalog
GNU General Public License v3.0
26 stars 18 forks source link

Added initial MP sourcefiles #120

Closed ronaldbckl closed 2 years ago

ronaldbckl commented 2 years ago

Unpacked an old version of the pack and rebuild the repository

Thanks for helping contribute to the MP Catalog. Please check the contribution guidelines with any questions, then fill out the below blanks.

What does this add/fix?

It brings back the managementpack in the repository

Does this close any currently open issues?

Yes, #116

Any other comments?

Like to enhance the pack since it now failed to discover a lot of docker daemons.

P2P-Nathan commented 2 years ago

Hello @ronaldbckl , thanks for making a pull request against the Management Pack Catalogue. We typically do not include the management pack source in the catalogue, and only a link to where the MP can be found.

I see your notes on the current version being unavailable, do you know if this source is available at another location that we could link to?

Thanks again, Nathan

ronaldbckl commented 2 years ago

Hi,

Sorry, I'm not an experienced github developer, i thought it was desired to add the source code so everybody can help to make it better. I will remove the sourcefiles if you like.

The original version is only available via thewaybackmachine. But you've added the pack originally, can't you see where it went?

Gr, Ronald

Op ma 15 nov. 2021 om 15:58 schreef Nathan Foreman @.***

:

Hello @ronaldbckl https://github.com/ronaldbckl , thanks for making a pull request against the Management Pack Catalogue. We typically do not include the management pack source in the catalogue, and only a link to where the MP can be found.

I see your notes on the current version being unavailable, do you know if this source is available at another location that we could link to?

Thanks again, Nathan

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MPCatalog/scom-community-catalog/pull/120#issuecomment-968993438, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVGPIOHLJI5DCMY3ALQQ3LUMEN2FANCNFSM5IBTGPPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Gr, Ronald

P2P-Nathan commented 2 years ago

Hello Ronald,

I appreciate the work you put into collecting the source files. I'm busy with a SCOM event much of this week (https://scomathon.com/hackascom-2021/) but will take a look on Friday at what our options are and send a proper response your way.

Thanks, Nathan

P2P-Nathan commented 2 years ago

Hello @ronaldbckl

Do you have a repository we could create for the community to build the new and improved Docker management pack?

We have updated the download link on the management pack to the old version, but I would like to be able to provide the GitHub repo for the community to keep growing.

If it would help I would be glad to create the dedicated Repo with the code you have been working on.

Thanks again for all your help to the community. -Nathan

ronaldbckl commented 2 years ago

Hi Nathan,

I'm not an experienced github user so i think i miss the point of your question. I've forked you'r project and therefore it's a repository of it's own: ronaldbckl https://github.com/ronaldbckl / scom-community-catalog https://github.com/ronaldbckl/scom-community-catalog Maybe you mean I should create a repository only for the docker pack, not for the whole community catalog? Wouldn't it be more desirable to work and enhance the original repository: MPCatalog/scom-community-catalog https://github.com/MPCatalog/scom-community-catalog ?

And please don't thank me for my work, I only split up the original managementpack in code blocks of what I believe you've created initially so all credits go to you. If it was not you then ..mmm Again, the pack has issues i would like to resolve but missing some knowledge so i hope to get in contact with people that can help.

Greetings, Ronald

Op di 14 dec. 2021 om 18:39 schreef Nathan Foreman @.***

:

Hello @ronaldbckl https://github.com/ronaldbckl

Do you have a repository we could create for the community to build the new and improved Docker management pack?

We have updated the download link on the management pack to the old version, but I would like to be able to provide the GitHub repo for the community to keep growing.

If it would help I would be glad to create the dedicated Repo with the code you have been working on.

Thanks again for all your help to the community. -Nathan

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MPCatalog/scom-community-catalog/pull/120#issuecomment-993821025, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVGPIINP4LYSKQSM6INRHTUQ56OHANCNFSM5IBTGPPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Gr, Ronald

P2P-Nathan commented 2 years ago

Hello @ronaldbckl

Sorry for the delay in getting back to you as it's been a busy couple of weeks. I have created a new repository that can be dedicated to this Docker Unix MP work. This new repository is at https://github.com/P2P-Nathan/Docker-Unix-Monitoring-Management-Pack and I have tried to pull over all of your hard work from the master branch fork.

The community catalogue is designed to only contain references to the MPs and not the actual source, so I will be closing this pull request, but hopefully have captured all of your work in the new repository.

We can also create issues and work on the new code from there.

ronaldbckl commented 2 years ago

Thank you Nathan,

I’m looking forward to work on this. Currently I’m on holiday and will look to this next week.

Greetings,

Ronald

Van: Nathan Foreman @.> Verzonden: woensdag 22 december 2021 12:14 Aan: MPCatalog/scom-community-catalog @.> CC: ronaldbckl @.>; Mention @.> Onderwerp: Re: [MPCatalog/scom-community-catalog] Added initial MP sourcefiles (PR #120)

Hello @ronaldbckl https://github.com/ronaldbckl

Sorry for the delay in getting back to you as it's been a busy couple of weeks. I have created a new repository that can be dedicated to this Docker Unix MP work. This new repository is at https://github.com/P2P-Nathan/Docker-Unix-Monitoring-Management-Pack and I have tried to pull over all of your hard work from the master branch fork.

The community catalogue is designed to only contain references to the MPs and not the actual source, so I will be closing this pull request, but hopefully have captured all of your work in the new repository.

We can also create issues and work on the new code from there.

— Reply to this email directly, view it on GitHub https://github.com/MPCatalog/scom-community-catalog/pull/120#issuecomment-999492681 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVGPIMNZG5SHBKZOOVAU7LUSGXJFANCNFSM5IBTGPPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ADVGPIO54E3QEOIHYUOJPRLUSGXJFA5CNFSM5IBTGPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHOJQYSI.gif Message ID: @. @.> >