search

MPCodeWriter21 / whois21

whois21 is a simple and easy to use python package that lets you easily query whois information of a domain/IP.
Apache License 2.0
26 stars 1 forks source link

something could be improve？ #7

Open Yang-ST opened 10 months ago

Yang-ST commented 10 months ago

Hello, I'm here again. The process of obtaining whois information is: get domain ->get whois server from iana ->get domain whois information, right? I'm not sure if I'm using the whois server.txt downloaded from iana, but that file may not have been updated for a long time. It would be more accurate to query the whois server from iana each time.

In addition, after multiple uses, I have found several areas for improvement:

  1. Date extraction: 'coli688. com. hk', the name of the creation time is' Domain Name Comment Date '. My solution is to generalize the date name, and skip if the date cannot be matched.

  2. Date format recognition: It is not always in accordance with iso specifications, such as 13-10-2009, 2022-11-10 00:00:00T00:00:Z. It is recommended to use the dateutil library and extract fixed date formats. "pip python-dateutil"

MPCodeWriter21 commented 10 months ago

Hello,

Thank you for taking the time to report this issue and provide your suggestions. I genuinely appreciate your input, and I'll certainly look into implementing these improvements for whois21 package.

Your feedback is valuable, and it's great to know that you're interested in making the package better. I'm actually planning to work on some new features, and your suggestions align with the improvements I had in mind.

If you're eager to see these changes happen sooner, feel free to fork the repository and submit your pull requests. Collaboration is always welcome!

Thanks again for your contribution and interest in enhancing whois21.

Best regards.