MPEGGroup / FileFormat

MPEG file format discussions
20 stars 0 forks source link

Feedback on draft Amendment 3 for Image File Format #103

Open bradh opened 1 week ago

bradh commented 1 week ago

Comments on working draft at https://www.mpeg.org/wp-content/uploads/mpeg_meetings/146_Rennes/w23988.zip

For the version 1 of PixelInformationProperty (pixi):

For the compressed meta box:

In P.2, the statement that 23008-12 is a Publically Available Standard on the ITTF page is (sadly) no longer true. While that might still be in work, perhaps we should just reference "ISO/IEC 23008-12" and be silent on the location. Updating the other MIME type registrations can be left for a future contribution.

y-guyon commented 5 days ago

Thank you for the feedback.

If we'd called it bits_per_channel_minus_one we could have got there, but a bit late to change the semantics.

Too late because we are at AMD WD stage or because it would be too confusing compared to 'pixi' version 0?
If doable I think it is a reasonable change.

I also couldn't find the right part in ISO/IEC 23091-2 for the definition for GenericSubsamplingType

Same. Should we keep only Rec. ITU-T H.273 as reference or are we confident enough that ISO/IEC 23091-2 will be updated before this amendment draft is published?

In the semantics for channel_idc: "Values 3-8 are reserved for future use." That should say "Values 3-7 are reserved...", since there are only three bits.

Good catch.

It seems like there is a lot of finessing to make it still be 'meta'

I agree.

Possibly there could actually be two compact versions - a really simple one that doesn't allow much (maybe just image + alpha), and is well suited to simple web page images, and a second one with the full tools.

"The second one with the full tools" would be regular HEIF, right?
Otherwise, introducing an alternative representation of HEIF is already a big change. Introducing two would be confusing in my opinion.

In P.2, the statement that 23008-12 is a Publically Available Standard on the ITTF page is (sadly) no longer true

Right.

farindk commented 5 days ago
  • it might be slightly cleaner if channel_data_type used the same enumeration values as 23001-17 Table 2 (plus AMD 2, which adds 3 for signed integer).

This, and we're also missing the 'complex' data type from 23007-17. That could be the reserved '3', but then we are already out of space. Thus, it might be good to increase the size of channel_data_type by one bit. There are still two reserved bits left.

bradh commented 5 days ago

"The second one with the full tools" would be regular HEIF, right? Otherwise, introducing an alternative representation of HEIF is already a big change. Introducing two would be confusing in my opinion.

I was thinking the met2 (or whatever we call it) with version=0 for the absolute minimum that we can agree on; then version=1 with the rest of the tools.

bradh commented 5 days ago

If we'd called it bits_per_channel_minus_one we could have got there, but a bit late to change the semantics.

Too late because we are at AMD WD stage or because it would be too confusing compared to 'pixi' version 0? If doable I think it is a reasonable change.

My original assessment was based on version 0 already being defined and widely implemented and version 1 inheriting all of version 0. A different design could definitely be an option if that didn't contravene some rules I don't understand.