MPEGGroup / FileFormat

MPEG file format discussions
23 stars 0 forks source link

ISOBMFF Restricted sample entry transformation #25

Closed lkondrad closed 1 year ago

lkondrad commented 3 years ago

based on 6th edition 14496-12, clause 8.15.2

A restricted sample entry is defined as a sample entry on which the following transformation procedure has been applied: 1) The four character code of the sample entry is replaced by a new sample entry code 'resv' meaning restricted video. 2) A RestrictedSchemeInfoBox is added to the sample description, leaving all other boxes unmodified. 3) The original sample entry type is stored within an OriginalFormatBox contained in the RestrictedSchemeInfoBox.

the second bullet says that RestrictedSchemeInfoBox is added to the sample description, which I was initially interpreting as SampleDescriptionBox. However, clause 8.15.3.1 says that RestrictedSchemeInfoBox is stored in Restricted Sample Entry or Sample Entry which I believe is the correct behaviour.

For clarity, I would proposed to correct the second bullet point to

2) A RestrictedSchemeInfoBox is added to the sample description sample entry, leaving all other boxes unmodified.

podborski commented 3 years ago

Note that the same also applies to clause 8.17.2:

2) A CompleteTrackInfoBox is added to the sample description, leaving all other boxes unmodified.

Also note that the term sample description is clearly defined as:

3.1.35 sample description structure which defines and describes the format of some number of samples in a track

So by this definition sample description = sample entry, right? As the SampleDescriptionBox is just a table of 1 or more sample entries and only a sample entry can describe "some number of samples in a track" using the reference index. Maybe it is also worth it to add a definition of sample entry to clause 3.1?

cconcolato commented 2 years ago

In the 7th edition, there are:

I would recommend:

jeanlf commented 2 years ago

shouldn't we pick one and stick with it rather than using two different terms for the same thing ? We could of course keep the two terms defined and say that derive specifications might use one or the other, but termX is preferred.

dwsinger commented 2 years ago

see the WD of amendment (which does a large amount of cleaning up):

A restricted sample entry is defined as a sample entry on which the following transformation procedure has been applied: 1) The four character code of the sample entry is replaced by a new sample entry code as defined in table X below. 2) A RestrictedSchemeInfoBox is added to the sampleentry, leaving all other boxes unmodified. 3) The original sample entry type is stored within an OriginalFormatBox contained in the RestrictedSchemeInfoBox.

yes, there is a space missing. sigh

cconcolato commented 2 years ago

@dwsinger I think the WD of Amendment should have a note saying that previous editions used the term "sample description" to mean "sample entry". Both have been used interchangeably for many years, it would be good to not invalidate all documents that use "sample description".

dwsinger commented 2 years ago

Add a note saying that sample description has also been used as a name for a sample entry.