search

MPH-Bali / green-village-project

Powering MPH recycling and composting facilities in Bali
MIT License
9 stars 8 forks source link

Add stock table needs to show "Type" column #219

Closed sovesove closed 6 years ago

sovesove commented 6 years ago

https://mph-bali.firebaseapp.com/manager/stock

image

mediashane commented 6 years ago

So even though the table is called Plastics there should still be a Type: Plastics column header in the table? It's easy to do, I just wanted to make sure we're not duplicating efforts.

On Wed, Mar 28, 2018, 6:28 PM Andrea notifications@github.com wrote:

https://mph-bali.firebaseapp.com/manager/stock

[image: image] https://user-images.githubusercontent.com/940045/38023784-c041c098-32b5-11e8-9452-7ed0511057c4.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MPH-Bali/green-village-project/issues/219, or mute the thread https://github.com/notifications/unsubscribe-auth/ANZT8AIWmBi_9TUKczHP5jyiGbKBLkITks5ti2W6gaJpZM4S-ZMY .

sovesove commented 6 years ago

No, this is related to the other issue where we would have "subtype" but Type and Subtype can be displayed in the same column as: Plastic - PTLE.

The goal is to display the subtype really, but how we can solve this depends on how you are implementing it I guess.

mediashane commented 6 years ago

I'd originally thought to separate the Type and Subtype drop-down menus out, but I see your logic here and will just combine them into one drop down. I'd originally wanted to split them up to keep the drop down menus shorter, but combining them makes it more simple for the user and for our data structure.

mediashane commented 6 years ago

So this was easy to implement on the Add Stock screen, but very difficult to manage on the Daily Log screen without the tables becoming messy and confusing. My temporary solution was to break out the Stock into different Daily Logs (so there is a Daily Log table for each stock type). Below is what the Stocks tables look like now on the Daily Log screen (Compost is collapsed, Plastics is expanded and showing Subtypes).

subtypesdaily

sovesove commented 6 years ago

Thanks Shane, looks like a good enough solution for the time being. Another solution could have been to also show the Type in the table, although I understand is redundant. We will iterate to understand what's best. 👍

nicksarafa commented 6 years ago

thanks @mediashane marking this one as closed