replace popup by confirm - Githubissues

MPIB / Lagerregal

Super awesome inventory System for electronic devices

Other

24 stars 10 forks source link

replace popup by confirm #308

Closed xi closed 5 years ago

xi commented 5 years ago

We have a lot of popups that just ask for a yes/no answer. For that there is a builtin confirm dialog. This has several benefits:

The current popup solution is not actually that great from a UX perspective. For example, the popups don't close when the containing dropdown closes.
Some inline JS is removed which is great for security (see #241). The workaround from #305 can be removed.
Accessibility is better.
Complexity is lower.

Unfortunately bootstrap3 does not support forms/buttons inside dropdowns. So this has to wait for #181.