Closed felipealbrecht closed 8 years ago
I did this for only the experiment datatable. I don't think it's necessary for the other datatable unless you say so.
Also, i implemented for only columns: Genome, Epigenetic marks, Projects, Techniques.
There are some UI bugs that may be introduced with the autocomplete dialog hanging differently if the UI dialog is open and the table columns resizes. Am considering using fixed column width for the table.
Please, do also for the BioSources column in the samples data table.
Please, implement also for the column BioSources in the experiments ID.
About the resize problems: is it possible to define a percentage of the data table width rather than a fixed column width? Using fixed column width is a very bad idea. We have users that access from low resolution screens (phone, tablets) to users that access from desktops.
Implemented for Biosources column in samples datatable Implemented for Biosources column in experiment datatable
Resize problem still remains even after usign percentages for the column and other ideas. The problem is once the content in the column becomes bigger, it resizes to fit the content even with autowidth set to false.
I didnt see the problem with resizing, may you explain me how it does affect ?
Overall, it seems very good.
Small points:
Should i hard code values of the column types?
No, I honestly do not remember by heart, but I think that in the list_in_use.php we call the faceting_experiments command, this command returns the experiments types being used.
Pay attention that you will get three values: "signal", "peaks", and "". The empty one is a bug that I am already working on. Dont do any special treatment for the empty value, but dont worry when you see it. It must be ~8 experiments in this case and they will be removed asap.
Please, ask me if you still have question.
Obaro Odiete wrote:
Should i hard code values of the column types?
— Reply to this email directly or view it on GitHub https://github.com/MPIIComputationalEpigenetics/DeepBlue-Web/issues/75#issuecomment-170069698.
Try to use an autocomplete component in the input box of the data tables.
Important: Verify if the data table changes after changing the input data. Bonus: Only reload the data table after the user press