MPowerKit / VirtualizeListView

.NET MAUI ListView renderers. Improves performance for MAUI ListView, adds additional behaviors
MIT License
69 stars 10 forks source link

.net8 not supported #15

Closed MichaelFrenkel closed 1 month ago

MichaelFrenkel commented 1 month ago

.net8 support was dropped in 1.2.0, is it intentional?

Alex-Dobrynin commented 1 month ago

Do you need that? It is not relevant, since project has all platforms included explicitly in .csproj

btw, use 1.2.2

MichaelFrenkel commented 1 month ago

yes, we have .net8 target for testing purposes

Alex-Dobrynin commented 1 month ago

I may include it, but the project itself contains precomiler conditions which will not work with raw .net8

MichaelFrenkel commented 1 month ago

okay, let me double-check that adding .net8 target will work for us

Alex-Dobrynin commented 1 month ago

I may release new version with included .net8 target. I checked, works properly

MichaelFrenkel commented 1 month ago

as I see, there are 2 places that prevent adding .net8.0

#if !WINDOWS
            handlers.AddHandler<FixedRefreshView, FixedRefreshViewRenderer>();
#endif
public virtual void AdjustScroll(double dx, double dy)
    {
        AdjustScrollRequested?.Invoke(this, (dx, dy));

#if MACIOS
        var scroll = this.Handler?.PlatformView as UIKit.UIScrollView;
        scroll?.SetContentOffset(new(ScrollX + dx, ScrollY + dy), false);
#elif WINDOWS
        var scroll = this.Handler?.PlatformView as Microsoft.UI.Xaml.Controls.ScrollViewer;
        scroll?.ChangeView(ScrollX + dx, ScrollY + dy, null, true);
#else
        var scroll = this.Handler?.PlatformView as SmoothScrollView;
        scroll?.AdjustScroll(dx, dy);
#endif
    }
Alex-Dobrynin commented 1 month ago

yes, already fixed this and added .net8 target, wait for v1.2.3