search

MPvHarmelen / Freevle

A good looking website package for schools, including visual awesomeness & an easy as pie CMS
http://freevle.org
10 stars 4 forks source link

Fix long slug problem #208

Closed PimTT closed 10 years ago

PimTT commented 10 years ago

schermafbeelding 2013-10-22 om 20 48 06

MPvHarmelen commented 10 years ago

Why is this a problem? The only place a slug is used is in the url, and who care for it being accurate but long? To be honest, I think this is a 'long title problem', because one shouldn't want a title that long.

FMJansen commented 10 years ago

It's a design problem; When the slug exceeds a certain size, it pushes down the buttons. This is not a real big problem though, since it doesn't look extremely bad and indeed, one shouldn't make such a long title.

MPvHarmelen commented 10 years ago

Can't you limit the text field with a certain length? The database has a limited length for the title too, so these should match.

FMJansen commented 10 years ago

I can, what is that length?

On Wed, Oct 23, 2013 at 2:37 PM, Martin notifications@github.com wrote:

Can't you limit the text field with a certain length? The database has a limited length for the title too, so these should match.

— Reply to this email directly or view it on GitHubhttps://github.com/Freevle/Freevle/issues/208#issuecomment-26900871 .

martijnarts commented 10 years ago

Why is this a problem? The only place a slug is used is in the url, and who care for it being accurate but long?

This is a problem. Would you want to link someone to http://www.cygnusgymnasium.nl/news/je-moeder-op-een-bakfiets-gaat-heelhard-en-nu-gaat-het-design-langzaam-stuk-wacht-maar-nu-gaat-het-pas-echt-goed-fout-je-weet-zelfwantalles-gaat-lekkaahr/? (Idk the actual URL structure) The correct answer is no. http://www.cygnusgymnasium.nl/news/je-moeder-op-een-bakfiets-gaat-heelhard/ would be much better.

Limit slug length!