MRC-CSO-SPHSU / LoneParentsModel.jl

An initial implementation of an ABM for social and child care
0 stars 5 forks source link

agestepAlive should not be needed #35

Closed mhinsch closed 2 years ago

mhinsch commented 2 years ago

Maybe it is actually required, but in first approximation I would say that if a population has agents that are not alive mixed in something is wrong.

AtiyahElsheikh commented 2 years ago

Indeed,

This can be changed in

function setup!(sim::MABMSimulation,example::LPMUKDemographyOpt) 

First translation version was not removing dead agents, i.e. the example=LPMUKDemography()rather than example=LPMUKDemographyOpt(). This could be also changed that dead agents to be stored in another population. (for statistical purposes) and this is what, as far as I remember, the original code does.

mhinsch commented 2 years ago

I see. I guess it also depends on how the rest of the model is organised (e.g. whether order of agents matters or if dead agents are referenced somewhere else).