search

MRC-CSO-SPHSU / LoneParentsModel.jl

An initial implementation of an ABM for social and child care
0 stars 4 forks source link

DoBirths() #64

Closed AtiyahElsheikh closed 2 years ago

AtiyahElsheikh commented 2 years ago

This is initial plain translation of DoBirths() It is the plain translation because it was started before writing the described model. I left an empty interface for DoBirthsOpt() that is going to be done in a later stage. Sorry for the large number of commits. Got out of hand. Will try to reduce pull-request sizes in future. I will lookup the conflict soon (probably due to the seed)

AtiyahElsheikh commented 2 years ago

yes, conflict resolved

mhinsch commented 2 years ago

Looks good. The only nitpick I have is that I would prefer functions to receive plain parameter objects without having to select the relevant sub-objects (see my comment on one of the commits). This is 1) simply a matter of keeping interfaces lean and 2) it makes it easier to change the layout of the parameter handling without having to change a gazillion small functions everywhere.

AtiyahElsheikh commented 2 years ago

Explaination here

AtiyahElsheikh commented 2 years ago

the original way retained.