MRC-CSO-SPHSU / LoneParentsModel.jl

An initial implementation of an ABM for social and child care
0 stars 5 forks source link

Rearchitecture simulate #78

Closed AtiyahElsheikh closed 2 years ago

AtiyahElsheikh commented 2 years ago

resolves #77

Going to work afterwards on #74 (refactoring iteration) & potentially #65 (lazy iterators)

AtiyahElsheikh commented 2 years ago

I have also fixed the arguments of checkassumptions & verbose in the main simualtion

mhinsch commented 2 years ago

Fine with me, but I think the return value of the main script should not be determined by verbose.

AtiyahElsheikh commented 2 years ago
mhinsch commented 2 years ago

Looks good, but please don't change the return value of Main* depending on the verbose parameter. Verbose has nothing to do with the return value.

AtiyahElsheikh commented 2 years ago

Multiple simulations with fixed seed was still random. This is because inputs generation was not seed-dependent. This is not hopefully fixed