Code refactoring/docs/tests

MRC-CSO-SPHSU / effect_estimates

GNU General Public License v3.0

1 stars 1 forks source link

Code refactoring/docs/tests #4

Open vkhodygo opened 2 years ago

vkhodygo commented 2 years ago

[ ] Reduce the size
[ ] Introduce more general functions, no hardcoded names
[ ] Add docstrings
[ ] Add tests

vkhodygo commented 1 year ago

@andrewbaxter439

How good are your R testing skills? I'd like to write some, but my experience with functional languages and R in particular is limited. I also have a suspicion I need to modify the code to follow some conventions and make it more well-structured.

andrewbaxter439 commented 1 year ago

I would say that I get the principles of testing, can understand functional languages and can apply testing using testthat to R function outputs, but thus far haven't paid it much attention! Would it be useful to chat over what tests would most suitably be used?

vkhodygo commented 1 year ago

That sounds good, designing everything in advance seems to be practical.