MRCIEU / gwas2vcf

Convert GWAS summary statistics to VCF
MIT License
47 stars 18 forks source link

pylint: variable names fixes #73

Closed darked89 closed 2 years ago

darked89 commented 2 years ago

Mostly single letter variable names fixes pylint was complaining about. IMHO _col_num as a suffix is more readable than _field for input column indexes, but it is just a proposal.

darked89 commented 2 years ago

Test failed because the gwas.py method had a spelling error: check_allelesarevaild' which I did change to: "check_allelesarevalid'

So it needs to be changed also in:

test/test_gwas.py
14:    g.check_alleles_are_vaild()
20:        g.check_alleles_are_vaild()
mcgml commented 2 years ago

Thanks @darked89 !