Fixes for CRAN/Bioconductor

MRCIEU / ieugwasr

R interface to the IEU GWAS database API

https://mrcieu.github.io/ieugwasr/

Other

76 stars 23 forks source link

Fixes for CRAN/Bioconductor #20

Closed remlapmot closed 2 years ago

remlapmot commented 2 years ago

These get this down to R CMD check results of 0 errors ✔ | 0 warnings ✔ | 0 notes ✔; and an OK when R CMD check is run under the Bioconductor R CMD check settings.

I didn't bump the version nor rebuild the pkgdown site - am happy to add either/both if you like.

explodecomputer commented 2 years ago

This is phenomenal thanks Tom

remlapmot commented 2 years ago

My pleasure Gib.

I have similar coming for some of the other packages.

Just to flag one issue to you - which has a simple fix - for data packages such as MRInstruments we may need to setup our own drat R package repository to host them - not hard to do I think, details here - as it's file size is greater than that allowed on both CRAN and Bioconductor. Or it would need to be classed as an ExperimentData package on Bioconductor - see list here - we'll chat more about this.