MRChemSoft / mrchem

MultiResolution Chemistry

GNU Lesser General Public License v3.0

29 stars 21 forks source link

Few CMake fixes #300

Closed robertodr closed 4 years ago

MinazoBot commented 4 years ago

	1 Warning
:warning:	There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by :no_entry_sign: Danger

stigrj commented 4 years ago

These are for the linking order warnings?

robertodr commented 4 years ago

These are for the linking order warnings?

Forgot to describe what I did... Yes, these fix those warnings and also disallow CMake from being "too eager" in searching for dependencies.

codecov[bot] commented 4 years ago

Codecov Report

Merging #300 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   38.60%   38.60%           
=======================================
  Files         168      168           
  Lines       11747    11747           
=======================================
  Hits         4535     4535           
  Misses       7212     7212

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4521ae...29292cd. Read the comment docs.

stigrj commented 4 years ago

I still get these warnings...

robertodr commented 4 years ago

Was this on a fresh copy with no installations around?

stigrj commented 4 years ago

Yes, fresh copy. First install is fine, then

$ touch src/input/mrchem.in

and a new make gives (without removing the old install)

-- Configuring done
CMake Warning at src/CMakeLists.txt:78 (add_executable):
  Cannot generate a safe runtime search path for target mrchem.x because
  there is a cycle in the constraint graph:

    dir 0 is [/home/stig/src/mrchem-master/build/lib]
      dir 1 must precede it due to runtime library [libxcfun.so.2]
    dir 1 is [/home/stig/src/mrchem-master/install/lib]
      dir 0 must precede it due to runtime library [libmrchem.so]

  Some of these libraries may not be found correctly.

stigrj commented 4 years ago

Should we still merge this?

robertodr commented 4 years ago

I'd merge: they don't solve the problem, but they don't hurt either.