robertodr commented 4 years ago

This fixes an obscure issue with dynamic linking that has annoyed @stigrj for quite a long time now. I still don't understand the original issue, but we agreed it's fine to have this fix in rather than break our teeth on getting dynamic linking right.

MinazoBot commented 4 years ago

	1 Warning
:warning:	There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by :no_entry_sign: Danger

codecov[bot] commented 4 years ago

Codecov Report

Merging #305 into master will increase coverage by 15.43%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #305       +/-   ##
===========================================
+ Coverage   38.53%   53.96%   +15.43%     
===========================================
  Files         168      105       -63     
  Lines       11773     8403     -3370     
===========================================
- Hits         4537     4535        -2     
+ Misses       7236     3868     -3368

Impacted Files	Coverage Δ
src/scf_solver/KAIN.h
src/scf_solver/GroundStateSolver.cpp
src/utils/gto_utils/AOContraction.cpp
src/initial_guess/core.cpp
src/qmoperators/RankTwoTensorOperator.cpp
src/scf_solver/LinearResponseSolver.cpp
src/utils/gto_utils/Intgrl.cpp
src/scf_solver/HelmholtzVector.cpp
src/scf_solver/Accelerator.h
src/utils/gto_utils/AOBasis.cpp
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3b9a7b...1a09e28. Read the comment docs.

stigrj commented 4 years ago

I also removed the STATIC_LIBRARY_ONLY line in fetch_xcfun.cmake which is no longer relevant

MRChemSoft / mrchem

Build libmrchem as static library #305

Codecov Report