Closed robertodr closed 4 years ago
Merging #315 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 53.96% 53.96%
=======================================
Files 105 105
Lines 8403 8403
=======================================
Hits 4535 4535
Misses 3868 3868
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e673d6...b02636d. Read the comment docs.
No, it's not.
On Tue, Sep 8, 2020, 16:44 Stig Rune Jensen notifications@github.com wrote:
@stigrj commented on this pull request.
In python/template.yml https://github.com/MRChemSoft/mrchem/pull/315#discussion_r484976955:
- name: quadrupole_moment
type: bool
- default: false
- default: true docstring: | Compute quadrupole moment. Note: Gauge origin dependent, should be used with
translate = true
in Molecule.Is the quadrupole moment always expected in the qcschema? I think our origin dependent definition is not very nice when the property is computed by default
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MRChemSoft/mrchem/pull/315#pullrequestreview-484213999, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JOEM2GLWMGIZ6RQSIORDSEY7NVANCNFSM4QUTB6LQ .
These are some changes necessary to run MRChem through QCEngine.
mrchem
Python module.provenance
section.success
field of the output schema. ~- [ ] Add a function to translate a QCElemental molecule specification to the format expected by the MRChem input schema~ ~- [ ] Add a function to translate between the MRChem output schema and the QCSchema output~The accompanying PR to QCEngine: MolSSI/QCEngine#269