MRChemSoft / mrchem

MultiResolution Chemistry
GNU Lesser General Public License v3.0
27 stars 21 forks source link

Bugfix in input parser (+ license updates to 2022) #403

Closed Brakjen closed 2 years ago

Brakjen commented 2 years ago

I noticed Visual Studio Code noticed an unused variable, though in an a-bit-unlikely-to-reach else clause. I renamed to what I deduced to be the correct variable.

And the githooks also complained about the year in the source file headers, so those were updated to 2022.

Oh, and clang-format also complained for a couple of files.

codecov[bot] commented 2 years ago

Codecov Report

Merging #403 (0efcd14) into master (b4f7849) will decrease coverage by 0.03%. The diff coverage is 82.75%.

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   68.91%   68.88%   -0.04%     
==========================================
  Files         180      180              
  Lines       14607    14580      -27     
==========================================
- Hits        10066    10043      -23     
+ Misses       4541     4537       -4     
Impacted Files Coverage Δ
pilot/mrchem.cpp 0.00% <ø> (ø)
src/analyticfunctions/CUBEfunction.cpp 0.00% <ø> (ø)
src/analyticfunctions/HydrogenFunction.cpp 61.34% <ø> (ø)
src/analyticfunctions/HydrogenFunction.h 66.66% <ø> (ø)
src/analyticfunctions/NuclearFunction.cpp 100.00% <ø> (ø)
src/analyticfunctions/NuclearFunction.h 100.00% <ø> (ø)
src/analyticfunctions/NuclearGradientFunction.cpp 97.36% <ø> (ø)
src/analyticfunctions/NuclearGradientFunction.h 100.00% <ø> (ø)
src/chemistry/Element.h 100.00% <ø> (ø)
src/chemistry/Molecule.cpp 66.91% <ø> (ø)
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4f7849...0efcd14. Read the comment docs.

stigrj commented 2 years ago

Btw @Andersmb, you should update your git email address to get your face on the commits

$ git config --global user.email "me@mymail.com"