Closed susilehtola closed 1 year ago
This appears to be related to changes in pyparsing api https://readthedocs.org/projects/pyparsing-docs/downloads/pdf/latest/
The culprit is commit c752bdbd419ba75c4aa2b279c43a279cd0bd2ba7
The calls have been changed to pyparsing 3 syntax for no reason, since the changelog states
camelCase names have been converted to PEP-8 snake_case names. Method names and arguments that were camel case (such as parseString) have been replaced with PEP-8 snake case versions (parse_string). Backward-compatibility synonyms for all names and arguments have been included, to allow parsers written using the old names to run without change. The synonyms will be removed in a future release. New parser code should be written using the new PEP-8 snake case names
MRChem bundles its own copy of pyparsing
. The bundling happens when we regenerate the parsing infrastructure with parselglossy
. Sadly, there was a tiny bug in the bundling, which has slipped through. The fix should propagate in a few days and Stig can mint 1.1.1
MRChem bundles its own copy of
pyparsing
. The bundling happens when we regenerate the parsing infrastructure withparselglossy
. Sadly, there was a tiny bug in the bundling, which has slipped through. The fix should propagate in a few days and Stig can mint 1.1.1
Why though? pyparsing is a standard package. Bundling should not be necessary; at the very least, it should be possible to turn it off...
Yes, it's a commonly used package, but it's not in the standard Python distribution. We made the choice to bundle to avoid having to install Python packages. The import statements will prefer system-installed pyparsing over the bundled one, if it's pyparsing>=3
Can the 2.x syntax not be restored?
Sorry for my absence. @robertodr is the fix ready? What exactly needs to be done on the MRChem side?
Fix is ready, but will require a new release (unless you want to edit the tag for 1.1.0) The attached patch restore 2.x syntax and I guess it can be applied during the Fedora build.
Great, thanks! I will make a new release including a fix for #426, hopefully by tomorrow.
Sorry for the delay, but now an official fix is finally out (v1.1.1). Closing this issue, but please re-open if the problem persists.
Updating to mrchem 1.1.0 results in test failures on Fedora.