Closed stigrj closed 1 year ago
Also added a warning if SCRF doesn't converge
Base: 68.40% // Head: 68.40% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
bac2d02
) compared to base (85db5f0
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Turned out to be a comically simple fix. By initializing the MO residual to
1.0
instead of-1.0
we trigger the dynamic threshold also for the 0th iteration. For cases when we want to compute the total energy accurately on the initial guess, usedynamic_thrs = false
.@Gabrielgerez please try this version on some real-world cases.
Closes #426