MRChemSoft / mrcpp

MultiResolution Computation Program Package
GNU Lesser General Public License v3.0
12 stars 19 forks source link

Add convenience constructor for BoundingBox and MRA #179

Closed stigrj closed 2 years ago

stigrj commented 2 years ago

Accepts [0,L] or [-L,L] arguments for world size, where L must be a positive integer.

codecov[bot] commented 2 years ago

Codecov Report

Merging #179 (64391f3) into master (268d238) will decrease coverage by 0.20%. The diff coverage is 5.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   65.60%   65.39%   -0.21%     
==========================================
  Files         172      172              
  Lines       12441    12479      +38     
==========================================
- Hits         8162     8161       -1     
- Misses       4279     4318      +39     
Impacted Files Coverage Δ
src/trees/BoundingBox.h 100.00% <ø> (ø)
src/trees/MultiResolutionAnalysis.cpp 65.47% <0.00%> (-8.85%) :arrow_down:
src/trees/MultiResolutionAnalysis.h 87.50% <ø> (-12.50%) :arrow_down:
src/trees/BoundingBox.cpp 81.21% <6.66%> (-14.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 268d238...64391f3. Read the comment docs.

robertodr commented 2 years ago

Isn't explicit only needed for 1-argument CTORs?

stigrj commented 2 years ago

These are all single argument with the defaults, no?

robertodr commented 2 years ago

Yes they are 😅