Closed ilfreddy closed 1 year ago
If anyone with access can make me admin for the documentation project on readthedocs.org, I can activate the documentation build on pull request. It will be easier to review changes such as these
I don't seem to be admin for mrcpp on readthedocs. Maybe @stigrj?
If anyone with access can make me admin for the documentation project on readthedocs.org, I can activate the documentation build on pull request. It will be easier to review changes such as these
I thought i enabled that already, but it is weird that it did not trigger on this PR. Is it not enough to just enable it in the advanced settings > Build pull requests for this project
?
According to the docs, yes, that's enough. Investigating...
The build starts, but then fails...
All modified lines are covered by tests :white_check_mark:
Comparison is base (
5320eb4
) 66.48% compared to head (e5262aa
) 66.48%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems it needed a re-sync of the github hook. Now it shows the documentation build in the list of PR checks. It's also building the docs.
Seems you need to debug the build on readthedocs before we can merge this. https://readthedocs.org/projects/mrcpp/builds/22034460/
I don't quite get it. The last time I commited the build on readthedocs (which i triggered manually by pushing to the rtd-build branch) was working just fine. So something must have happened in the meantime...
Seems it needed a re-sync of the github hook. Now it shows the documentation build in the list of PR checks. It's also building the docs.
How did you do this?
I don't quite get it. The last time I commited the build on readthedocs (which i triggered manually by pushing to the rtd-build branch) was working just fine. So something must have happened in the meantime...
did you do a rebase before creating the PR? I think it might be some other issues that are crashing though
Not clear to me what happened but the doc build seems fine now after I force-pushed my own version
This PR is btw from the rtd-build which is on upstream (not my own fork, my bad!).
How did you do this?
By reading the docs 😄 https://docs.readthedocs.io/en/stable/guides/pull-requests.html#troubleshooting
MWTree
andMWNode
classes are now sufficiently documented.Workflow to approve this pull request (and all other PRs about documentation)
NOTE: This PR includes quite a few more changes other than just in the
MWNode
andMWTree
classes because we had to refresh a few config files.