Closed robertodr closed 2 years ago
Merging #81 (422f8f9) into master (fc2e45c) will increase coverage by
5.44%
. The diff coverage is94.73%
.
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 81.03% 86.47% +5.44%
==========================================
Files 20 21 +1
Lines 696 880 +184
==========================================
+ Hits 564 761 +197
+ Misses 132 119 -13
Impacted Files | Coverage Δ | |
---|---|---|
src/vampyr/tests/test_arithmetics_1d.py | 100.00% <ø> (ø) |
|
src/vampyr/trees/trees.h | 87.31% <94.73%> (-3.52%) |
:arrow_down: |
src/vampyr/operators/convolutions.h | 100.00% <0.00%> (+1.81%) |
:arrow_up: |
src/vampyr/treebuilders/project.h | 84.21% <0.00%> (+2.63%) |
:arrow_up: |
src/vampyr/treebuilders/applys.h | 100.00% <0.00%> (+4.54%) |
:arrow_up: |
src/vampyr/trees/world.h | 80.32% <0.00%> (+4.91%) |
:arrow_up: |
src/vampyr/treebuilders/arithmetics.h | 100.00% <0.00%> (+6.66%) |
:arrow_up: |
src/vampyr/treebuilders/grids.h | 100.00% <0.00%> (+8.16%) |
:arrow_up: |
... and 1 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The CMake-only build workflow is not running any tests, I'm trying to figure out why and fix it
The CMake-only build workflow is not running any tests, I'm trying to figure out why and fix it
The tests are now running. Don't know why 🤷🏻 but I'll take it 😄
When this is merged, one can run:
and get a working installation of the package. An editable installation is convenient when one is developing the Python code exclusively: a copy of the shared library containing the C++ extensions is placed in
src/vampyr
and one does not need topip install
anymore to test changes in the Python files.NOTE The tests moved to
src/vampyr/tests
, in accordance with the suggestion here: https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#tests-as-part-of-application-code